This repository was archived by the owner on Sep 30, 2024. It is now read-only.
codeintel: allows batch retrieval of SCIP documents#64024
Merged
Conversation
88f8cd4 to
4ea51bb
Compare
7 tasks
4ea51bb to
c90986c
Compare
keynmol
reviewed
Jul 25, 2024
keynmol
reviewed
Jul 25, 2024
keynmol
left a comment
Contributor
There was a problem hiding this comment.
Ready to approve, just want some clarification on error possibly not being surfaced from scanner.
1d65b42 to
a706313
Compare
keynmol
approved these changes
Jul 25, 2024
kritzcreek
pushed a commit
that referenced
this pull request
Jul 25, 2024
…Index (#64073) Closes https://linear.app/sourcegraph/issue/GRAPH-770/batch-api-for-mappedindex Depends on #64024 ## Test plan Added unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/sourcegraph/issue/GRAPH-766/batch-api-for-fetching-scip-documents
Test plan
Tested by being used for the single-path retrieval path, will be tested more once its used in follow-up PRs with more batching