This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[logging] Only record events if a new user was created#64004
Merged
Conversation
eseliger
approved these changes
Jul 23, 2024
eseliger
left a comment
Member
There was a problem hiding this comment.
code LGTM but I have no idea what the event is supposed to measure so 🤷
sourcegraph-release-bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
(cherry picked from commit 777c7a0)
craigfurman
pushed a commit
that referenced
this pull request
Jul 23, 2024
…ed (#64005) Follow-up on https://github.com/sourcegraph/sourcegraph/pull/63843 Based on comments from [this](https://sourcegraph.slack.com/archives/C04RG0JD8L9/p1721668767261719?thread_ts=1721661216.365709&cid=C04RG0JD8L9) Slack thread, it seems like the events causing the spam are ones where a new ext acct is saved without a user being created. So if we want to fix the spam we need to only save an event if a user was created. ## Test plan Test updated. ## Changelog <br> Backport 777c7a0 from #64004 Co-authored-by: Petri-Johan Last <petri.last@sourcegraph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on https://github.com/sourcegraph/sourcegraph/pull/63843
Based on comments from this Slack thread, it seems like the events causing the spam are ones where a new ext acct is saved without a user being created. So if we want to fix the spam we need to only save an event if a user was created.
Test plan
Test updated.
Changelog