This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(appliance): make a function less misleading#63994
Merged
Conversation
isNamespaced was implemented the opposite way to its name, returning true when a resource was _not_ namespaced. We could have renamed it to isNotNamespaced, but then most callsites would look like a double negative. So this commit inverts the implementation to match the name, and also its callers.
craigfurman
approved these changes
Jul 22, 2024
craigfurman
pushed a commit
that referenced
this pull request
Jul 31, 2024
isNamespaced was implemented the opposite way to its name, returning true when a resource was _not_ namespaced. We could have renamed it to isNotNamespaced, but then most callsites would look like a double negative. So this commit inverts the implementation to match the name, and also its callers. <!-- PR description tips: https://www.notion.so/sourcegraph/Write-a-good-pull-request-description-610a7fd3e613496eb76f450db5a49b6e --> Forked from https://github.com/sourcegraph/sourcegraph/pull/63972 to clean up the branch ## Test plan <!-- REQUIRED; info at https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles --> CI ## Changelog <!-- OPTIONAL; info at https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c --> Co-authored-by: Craig Furman <craig.furman@sourcegraph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isNamespaced was implemented the opposite way to its name, returning
true when a resource was not namespaced. We could have renamed it to
isNotNamespaced, but then most callsites would look like a double
negative. So this commit inverts the implementation to match the name,
and also its callers.
Forked from https://github.com/sourcegraph/sourcegraph/pull/63972 to clean up the branch
Test plan
CI
Changelog