This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat(appliance): deploy otel-agent#63991
Merged
Merged
Conversation
craigfurman
commented
Jul 22, 2024
Chickensoupwithrice
approved these changes
Jul 22, 2024
Chickensoupwithrice
left a comment
Contributor
There was a problem hiding this comment.
🚀
Reasonable and straight forward
DaedalusG
approved these changes
Jul 23, 2024
c934663 to
ae240ca
Compare
ae240ca to
c31f2f3
Compare
craigfurman
pushed a commit
that referenced
this pull request
Jul 31, 2024
Relates to https://linear.app/sourcegraph/issue/REL-81/service-definition-otel-collector but does not close it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to https://linear.app/sourcegraph/issue/REL-81/service-definition-otel-collector but does not close it.
Stacked on https://github.com/sourcegraph/sourcegraph/pull/63989 - draft until that is merged, but can be reviewed somewhat independently (although if the service split is a poor idea, that probably changes).
I looked at compare-helm, but am holding off on a full diff review until the PR that adds the collector, since it'll be easier to read with both, given that they are the same component in Helm. As the appliance is unreleased, we can always make changes in the next PR.
Test plan
Golden tests included.
Changelog