This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat(appliance): redeploy various services when pg/redis config changes#63954
Merged
Conversation
added 6 commits
July 19, 2024 15:40
Chickensoupwithrice
approved these changes
Jul 19, 2024
Chickensoupwithrice
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Super helpful to go by commits :)
craigfurman
pushed a commit
that referenced
this pull request
Jul 31, 2024
…es (#63954) Builds on https://github.com/sourcegraph/sourcegraph/pull/63845, and closes https://linear.app/sourcegraph/issue/REL-14/ensure-pods-roll-when-referenced-secret-changes. When one of the 3 DB configs changes, an annotation "checksum/auth" on frontend's deployment's spec.template.metadata should change on next reconcile. This will cause pods to roll, picking up the new secret values. It should also cause the top-level annotation configHash to change, which indicates to the appliance that the kubernetes resource should be updated. A similar mechanism is implemented for "checksum/redis", on every service that uses redis (obtained by grepping the helm chart for the same annotation).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's probably best to review this commit-by-commit. Builds on https://github.com/sourcegraph/sourcegraph/pull/63845, and closes https://linear.app/sourcegraph/issue/REL-14/ensure-pods-roll-when-referenced-secret-changes.
When one of the 3 DB configs changes, an annotation "checksum/auth" on frontend's deployment's spec.template.metadata should change on next reconcile. This will cause pods to roll, picking up the new secret values. It should also cause the top-level annotation configHash to change, which indicates to the appliance that the kubernetes resource should be updated.
A similar mechanism is implemented for "checksum/redis", on every service that uses redis (obtained by grepping the helm chart for the same annotation).
Test plan
Golden tests included.
Changelog