This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(appliance): resource kind present on reconciler logs#63919
Merged
Conversation
It turns out that Kubernetes objects constructed using client-go don't know their own TypeMeta. There is code in client-go that figures out which resource-scoped HTTP path to call on the kube-apiserver by looking up a mapping of Go object kinds to k8s kinds. A similar facility appears to be exposed to the user by apiutil.GVKForObject(). Closes https://linear.app/sourcegraph/issue/REL-275/reconciler-logs-dont-contain-resource-metadata.
jdpleiness
approved these changes
Jul 18, 2024
jdpleiness
left a comment
Contributor
There was a problem hiding this comment.
Went over this in 🍐 'ing.
craigfurman
pushed a commit
that referenced
this pull request
Jul 31, 2024
It turns out that Kubernetes objects constructed using client-go don't know their own TypeMeta. There is code in client-go that figures out which resource-scoped HTTP path to call on the kube-apiserver by looking up a mapping of Go object kinds to k8s kinds. A similar facility appears to be exposed to the user by apiutil.GVKForObject(). Closes https://linear.app/sourcegraph/issue/REL-275/reconciler-logs-dont-contain-resource-metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that Kubernetes objects constructed using client-go don't know their own TypeMeta. There is code in client-go that figures out which resource-scoped HTTP path to call on the kube-apiserver by looking up a mapping of Go object kinds to k8s kinds. A similar facility appears to be exposed to the user by apiutil.GVKForObject().
Closes https://linear.app/sourcegraph/issue/REL-275/reconciler-logs-dont-contain-resource-metadata
Test plan
Ran
go test -v ./internal/appliance/reconciler, saw kinds present in logs.Changelog