Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Feature(appliance): db connection pinger and validator#63884

Merged
DaedalusG merged 20 commits into
mainfrom
wg/rel/appliance-upgrade-utils
Jul 22, 2024
Merged

Feature(appliance): db connection pinger and validator#63884
DaedalusG merged 20 commits into
mainfrom
wg/rel/appliance-upgrade-utils

Conversation

@DaedalusG

@DaedalusG DaedalusG commented Jul 17, 2024

Copy link
Copy Markdown
Contributor

Introduce a pinger for the appliance to poll the various Sourcegraph dbs and ensure connection is possible given the current connection envvar configuration.

Test plan

Unit Tests

Changelog

@cla-bot cla-bot Bot added the cla-signed label Jul 17, 2024
@jdpleiness jdpleiness self-requested a review July 19, 2024 17:37
@DaedalusG DaedalusG marked this pull request as ready for review July 19, 2024 19:07
Comment thread internal/appliance/upgrades/util.go Outdated
@Chickensoupwithrice

Copy link
Copy Markdown
Contributor

Hell yeah dude! ~
Asides from the minor nit, LGTM 🥳

@DaedalusG DaedalusG enabled auto-merge (squash) July 22, 2024 22:22
@DaedalusG DaedalusG merged commit 0e391a9 into main Jul 22, 2024
@DaedalusG DaedalusG deleted the wg/rel/appliance-upgrade-utils branch July 22, 2024 22:34
craigfurman pushed a commit that referenced this pull request Jul 31, 2024
Introduce a pinger for the appliance to poll the various Sourcegraph dbs
and ensure connection is possible given the current connection envvar
configuration.

## Test plan

Unit Tests

<!-- REQUIRED; info at
https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles
-->

## Changelog

<!-- OPTIONAL; info at
https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c
-->
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants