This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Cody: add support for neovim, cody-cli, eclipse, and visualstudio clients#63851
Merged
Conversation
…ents Fixes CODY-2884 Previously, the server could respond with a 406 error when encountering clients with the following names: cody-cli, eclipse, and visualstudio. This error seems to only happen for enterprise clients. This PR fixes the problem by adding special cases for these clients like we already have for jetbrains and cody web.
umpox
approved these changes
Jul 16, 2024
olafurpg
added a commit
that referenced
this pull request
Jul 16, 2024
…ents (#63851) Fixes CODY-2884 Previously, the server could respond with a 406 error when encountering clients with the following names: cody-cli, eclipse, and visualstudio. This error seems to only happen for enterprise clients. This PR fixes the problem by adding special cases for these clients like we already have for jetbrains and cody web. <!-- PR description tips: https://www.notion.so/sourcegraph/Write-a-good-pull-request-description-610a7fd3e613496eb76f450db5a49b6e --> ## Test plan See updated test case. <!-- REQUIRED; info at https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles --> ## Changelog - Fix HTTP 406 error when using the Neovim Cody plugin with Enterprise instances <!-- OPTIONAL; info at https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CODY-2884
Previously, the server could respond with a 406 error when encountering clients with the following names: cody-cli, eclipse, and visualstudio. This error seems to only happen for enterprise clients. This PR fixes the problem by adding special cases for these clients like we already have for jetbrains and cody web.
Test plan
See updated test case.
Changelog