This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Add OctopusMergeBase RPC method#63842
Merged
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
varungandhi-src
approved these changes
Jul 16, 2024
varungandhi-src
left a comment
Contributor
There was a problem hiding this comment.
LGTM modulo existing review comments
Contributor
There was a problem hiding this comment.
Same point as elsewhere wrt potentially logging a large number of strings; is logging all of them necessary/deliberate?
Member
Author
There was a problem hiding this comment.
I changed the other one, this one I am keeping as-is because exhaustive logging is meant for debugging, off by default, and supposed to help us understand why we might see performance issues
This method can be used to find a common ancestor for many commit SHAs, to be used by code intel for finding visible uploads. Closes SRC-481 Test plan: Added unit tests for the several layers (client, grpc, gitcli).
ba24e67 to
dafa858
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method can be used to find a common ancestor for many commit SHAs, to be used by code intel for finding visible uploads.
Closes SRC-485
Test plan: Added unit tests for the several layers (client, grpc, gitcli).