This repository was archived by the owner on Sep 30, 2024. It is now read-only.
refactor: upgrade to rules_oci 2.0 (2nd attempt)#63829
Merged
Merged
Conversation
734d117 to
90eab15
Compare
90eab15 to
83bf3fa
Compare
83bf3fa to
7abe3a9
Compare
d8b612b to
029ed8c
Compare
Strum355
approved these changes
Aug 7, 2024
Strum355
referenced
this pull request
Aug 7, 2024
Reverts sourcegraph/sourcegraph#63829 Not working with Aspect Delivery ## Test plan CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2nd attempt of #63111, a follow up https://github.com/sourcegraph/sourcegraph/pull/63085
rules_oci 2.0 brings a lot of performance improvement around oci_image and oci_pull, which will benefit Sourcegraph. It will also make RBE faster and have less load on remote cache.
However, 2.0 makes some breaking changes like
has to make sure all
pkg_tartargets have acompressionattributeset to compress it beforehand.
already uses bazel 7.1.
I checked all targets that use oci_tarball as much as i could to make sure nothing depends on the default tarball output of oci_tarball. there was one target which used the default output which i put a TODO for somebody else (somebody who is more on top of the repo) to tackle later.
Test plan
CI. Also run delivery on this PR (don't land those changes)