This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(batches): the baseURL for github instance is now updated when creating a GitHub app#63803
Merged
BolajiOlajide merged 1 commit intoJul 13, 2024
Conversation
camdencheek
approved these changes
Jul 12, 2024
sourcegraph-release-bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
…ating a GitHub app (#63803) Closes SRCH-723 The baseURL for GitHub apps defaults to `https://github.com` when no `externalServiceURL`, we somehow missed this during our testing.  ## Test plan <!-- REQUIRED; info at https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles --> Manual testing with the GHE instance. ## Changelog <!-- OPTIONAL; info at https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c --> (cherry picked from commit 1c40c9e)
Chickensoupwithrice
added a commit
that referenced
this pull request
Jul 17, 2024
… updated when creating a GitHub app (#63833) Closes SRCH-723 The baseURL for GitHub apps defaults to `https://github.com` when no `externalServiceURL`, we somehow missed this during our testing.  ## Test plan Manual testing with the GHE instance. ## Changelog <br> Backport 1c40c9e from #63803 Co-authored-by: Bolaji Olajide <25608335+BolajiOlajide@users.noreply.github.com> Co-authored-by: Anish Lakhwara <anish+github@lakhwara.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes SRCH-723
The baseURL for GitHub apps defaults to
https://github.comwhen noexternalServiceURL, we somehow missed this during our testing.Test plan
Manual testing with the GHE instance.
Changelog