Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Wolfi image for Sourcegraph Frontend#63798

Merged
craigfurman merged 3 commits into
mainfrom
nelsona/appliance/maint-wolfi
Jul 25, 2024
Merged

Wolfi image for Sourcegraph Frontend#63798
craigfurman merged 3 commits into
mainfrom
nelsona/appliance/maint-wolfi

Conversation

@nelsonjr

Copy link
Copy Markdown
Contributor

Creates the Wolfi image for the Appliance Maintenance UI

Test plan

bazel test \
      //internal/appliance/frontend/maintenance:image_test \
      //docker-images/appliance-frontend:image_test

@cla-bot cla-bot Bot added the cla-signed label Jul 12, 2024
@nelsonjr nelsonjr requested a review from jdpleiness July 12, 2024 06:22
- stat
- /etc/nginx/conf.d/maintenance.conf
- name: maintenance app is available
command: stat

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're just checking that the file exists, you can use fileExistenceTests:

fileExistenceTests:
- name: '/maintenance/index.html'
  path: '/maintenance/index.html'
  shouldExist: true

  # Optional permission checks
  uid: 100
  gid: 101

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Will change. Thanks!

@craigfurman craigfurman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me and the boys (https://github.com/sourcegraph/sourcegraph/pull/64059) have been hacking on top of this, let's get it merged and we can roll forward with any bug fixes

@craigfurman craigfurman merged commit 49b32fc into main Jul 25, 2024
@craigfurman craigfurman deleted the nelsona/appliance/maint-wolfi branch July 25, 2024 14:33
craigfurman pushed a commit that referenced this pull request Jul 31, 2024
Creates the Wolfi image for the Appliance Maintenance UI

## Test plan

```
bazel test \
      //internal/appliance/frontend/maintenance:image_test \
      //docker-images/appliance-frontend:image_test
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants