This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gateway: Don't panic because of duplicate env var registration#63787
Merged
jhchabran merged 2 commits intoJul 11, 2024
Merged
Conversation
`REDIS_ENDPOINT` is now registered by gateway, but it is also registered in `internal/redispool` as the fallback for when the other values are not set. The real fix would be to not have env vars in that package, and instead each service creates one instance of each of those two in their `cmd/`, but that's a lot of work so short-term fixing it by reading the fallback using os.Getenv. Test plan: `sg run cody-gateway` doesn't panic.
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jhchabran
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REDIS_ENDPOINTis now registered by gateway, but it is also registered ininternal/redispoolas the fallback for when the other values are not set.The real fix would be to not have env vars in that package, and instead each service creates one instance of each of those two in their
cmd/, but that's a lot of work so short-term fixing it by reading the fallback using os.Getenv.Test plan:
sg run cody-gatewaydoesn't panic.