This repository was archived by the owner on Sep 30, 2024. It is now read-only.
symbols: Make symbols specific code internal#63736
Merged
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
887dc9d to
539609f
Compare
This PR restructures the packages to move all symbols-only code into the symbols service. This helps to reason better about which service is accessing what datastores. Test plan: Just moved code, compiler and CI are happy.
539609f to
e10b7a5
Compare
camdencheek
approved these changes
Jul 9, 2024
camdencheek
left a comment
Member
There was a problem hiding this comment.
Woot! Always a fan of making more things private.
bahrmichael
referenced
this pull request
Jul 10, 2024
https://github.com/sourcegraph/sourcegraph/pull/63736 removed rockskip files, which lead to `sg start` failing because it was still watching those. This PR removes the watch and lets `sg start` succeed again. ## Test plan Existing CI, manual test of `sg start` ## Changelog <!-- OPTIONAL; info at https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restructures the packages to move all symbols-only code into the symbols service. This helps to reason better about which service is accessing what datastores.
Test plan:
Just moved code, compiler and CI are happy.