This repository was archived by the owner on Sep 30, 2024. It is now read-only.
symbols: Minor code cleanup#63708
Merged
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Was reading through the service, found these things and figured why not commit them. Test plan: CI.
4555895 to
0289f94
Compare
camdencheek
approved these changes
Jul 9, 2024
Comment on lines
-53
to
-54
| // Limits concurrency of outstanding HTTP posts | ||
| HTTPLimiter limiter.Limiter |
Member
Author
There was a problem hiding this comment.
we had the same on gitserver - also not used after gRPC. I added it back there - if someone feels strongly this service would also benefit from it there's prior art for that now :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was reading through the service, found these things and figured why not commit them.
Test plan:
CI.