This repository was archived by the owner on Sep 30, 2024. It is now read-only.
webhooks: Deterministically match webhook events to repos#63668
Merged
eseliger merged 1 commit intoJul 16, 2024
Conversation
Previously, we would attempt to recreate the clone URL of a repo based on event data. This is a lossy matching, and can cause events to get rejected, although we have the repo cloned. This PR changes the matching to instead use the external ID of the repo, which we already store in the repo table in a separate column. Closes SRC-40 Test plan: Tests still pass, set up webhooks locally and they still matched (but only tried GitHub).
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ggilmore
approved these changes
Jul 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we would attempt to recreate the clone URL of a repo based on event data. This is a lossy matching, and can cause events to get rejected, although we have the repo cloned.
This PR changes the matching to instead use the external ID of the repo, which we already store in the repo table in a separate column.
Closes SRC-40
Test plan:
Tests still pass, set up webhooks locally and they still matched (but only tried GitHub).