This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix/internal/observation: make ErrCollector type threadsafe#63496
Merged
ggilmore merged 1 commit intoJul 3, 2024
Merged
Conversation
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
|
@ggilmore is this ready for review? It's open but no reviewers requested yet :) |
Contributor
Author
|
@eseliger whoops sorry, I just added y'all |
eseliger
approved these changes
Jul 3, 2024
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/sourcegraph/issue/SRC-410/race-in-gitserver-observability
This PR adds a mutex to the internal/observation.ErrCollector type that makes it safe to use across multiple goroutines.
(This could quite easily happen, as the FinishFunc's OnCancel method runs the logic that accesses/modifies ErrReporter in a separate goroutine:)
https://github.com/sourcegraph/sourcegraph/blob/fa46a26f7a7d3d13833cc7917aaee42d1c94eff9/internal/observation/observation.go#L156-L170
Test plan
CI now passes and doesn't report race conditions
Changelog