This repository was archived by the owner on Sep 30, 2024. It is now read-only.
cloud: add feature flags to show no edit warning#63484
Merged
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @michaellzc and the rest of your teammates on |
a5458d3 to
3575303
Compare
eseliger
approved these changes
Jun 26, 2024
eseliger
left a comment
Member
There was a problem hiding this comment.
non blocking feedback inline
Member
There was a problem hiding this comment.
May sounds vague to me - could we say "don't use this" or even hide the page?
Member
Author
There was a problem hiding this comment.
😅 it's technically "may be" because we do support customer-managed feature flag, but it has to be opt-in on a per flag basis.
https://github.com/sourcegraph/controller/pull/1198
but yes, let's just say "will be" to make it less confusing cuz it's a niche-use case
filiphaftek
approved these changes
Jun 26, 2024
3575303 to
039a8ed
Compare
michaellzc
referenced
this pull request
Jun 26, 2024
https://github.com/sourcegraph/sourcegraph/pull/63484 got feedback from teammates that it shouldn't be `warning` but `info` warning usually indicates something is wrong, this is not the case.
michaellzc
referenced
this pull request
Jun 27, 2024
follow up https://github.com/sourcegraph/sourcegraph/pull/63484 got feedback from teammates that it shouldn't be `warning` but `info` warning usually indicates something is wrong, this is not the case. <!-- PR description tips: https://www.notion.so/sourcegraph/Write-a-good-pull-request-description-610a7fd3e613496eb76f450db5a49b6e --> ## Test plan <!-- REQUIRED; info at https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles --> ## Changelog <!-- OPTIONAL; info at https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c --> n/a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref CLO-380
on Cloud, customer changes to feature flags are overridden by our automation. let's add a warning message to avoid suprises.
Test plan