This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/enterpriseportal: use UUID type for subscription ID#63452
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bobheadxi and the rest of your teammates on |
This was referenced Jun 24, 2024
unknwon
approved these changes
Jun 25, 2024
Contributor
For safety reason, it only adds addition or compatible/broader type changes |
bobheadxi
referenced
this pull request
Jun 27, 2024
The idea is to have a table of conditions which track reasons etc for major changes to a subscription. These aren't critical - important state still gets a subscription table time field for querying - but should match. Closes https://linear.app/sourcegraph/issue/CORE-155 ## Test plan Apply https://github.com/sourcegraph/sourcegraph/pull/63452, then `sg run enterprise-portal`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were aligned on using non-prefixed UUIDs internally, only prefixing them for external consumption. This lets us use the native UUID type.
Part of https://linear.app/sourcegraph/issue/CORE-155
Test plan
CI,
sg run enterprise-portalselect * from enterprise_portal_subscriptions;on dev shows we are using the non-prefixed UUDs only. Manual migration, since it doesn't seem like GORM can do this for you:Checked that data is intact.