Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

feat/enterpriseportal: validate and normalize instance domains#63415

Merged
bobheadxi merged 5 commits into
mainfrom
ep-subscription-normalizedomain
Jun 21, 2024
Merged

feat/enterpriseportal: validate and normalize instance domains#63415
bobheadxi merged 5 commits into
mainfrom
ep-subscription-normalizedomain

Conversation

@bobheadxi

Copy link
Copy Markdown
Member

Validates domains on update (subscription and member) to ensure that we don't get anything too wonky.

Test plan

Tests

@cla-bot cla-bot Bot added the cla-signed label Jun 21, 2024
@bobheadxi bobheadxi marked this pull request as ready for review June 21, 2024 01:19
@bobheadxi bobheadxi requested a review from a team June 21, 2024 01:19
@bobheadxi bobheadxi force-pushed the ep-subscription-normalizedomain branch 2 times, most recently from e6d1701 to 90d61a6 Compare June 21, 2024 01:27
Comment thread lib/enterpriseportal/subscriptions/v1/v1_test.go Outdated
@bobheadxi bobheadxi force-pushed the ep-subscription-normalizedomain branch from a20d215 to f3f0683 Compare June 21, 2024 18:14
@bobheadxi bobheadxi requested review from a team and unknwon June 21, 2024 18:15

bobheadxi commented Jun 21, 2024

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bobheadxi and the rest of your teammates on Graphite Graphite

@bobheadxi bobheadxi force-pushed the ep-subscription-normalizedomain branch from bcf61e4 to 8170e1b Compare June 21, 2024 21:03
@bobheadxi bobheadxi merged commit 5770f30 into main Jun 21, 2024

Copy link
Copy Markdown
Member Author

Merge activity

@bobheadxi bobheadxi deleted the ep-subscription-normalizedomain branch June 21, 2024 23:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants