Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

dotcom: Remove on-demand cloning of repositories#63321

Merged
eseliger merged 1 commit into
mainfrom
es/06-18-experimentalnon-on-demand
Jun 26, 2024
Merged

dotcom: Remove on-demand cloning of repositories#63321
eseliger merged 1 commit into
mainfrom
es/06-18-experimentalnon-on-demand

Conversation

@eseliger

@eseliger eseliger commented Jun 18, 2024

Copy link
Copy Markdown
Member

Historically, sourcegraph.com has been the only instance. It was connected to GitHub.com and GitLab.com only.
Configuration should be as simple as possible, and we wanted everyone to try it on any repo. So public repos were added on-demand when browsed from these code hosts.

Since, dotcom is no longer the only instance, and this is a special case that only exists for sourcegraph.com.
This causes a bunch of additional complexity and various extra code paths that we don't test well enough today.

We want to make dotcom simpler to understand, so we've made the decision to disable that feature, and instead we will maintain a list of repositories that we have on the instance.
We already disallowed several repos half a year ago, by restricting size of repos with few stars heavily.
This is basically just a continuation of that.

In the diff, you'll mostly find deletions. This PR does not do much other than removing the code paths that were only enabled in dotcom mode in the repo syncer, and then removes code that became unused as a result of that.

Test plan

Ran a dotcom mode instance locally, it did not behave differently than a regular instance wrt. repo cloning.
We will need to verify during the rollout that we're not suddenly hitting code paths that don't scale to the dotcom size.

Changelog

Dotcom no longer clones repos on demand.

@cla-bot cla-bot Bot added the cla-signed label Jun 18, 2024
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Jun 18, 2024

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @eseliger and the rest of your teammates on Graphite Graphite

@eseliger eseliger force-pushed the es/06-18-experimentalnon-on-demand branch from 1422731 to 1935fb9 Compare June 21, 2024 22:21
@eseliger eseliger force-pushed the es/06-18-experimentalnon-on-demand branch 3 times, most recently from e33caea to e6e7edf Compare June 25, 2024 21:27
@eseliger eseliger force-pushed the es/06-18-experimentalnon-on-demand branch from e6e7edf to e1d2d3b Compare June 25, 2024 21:38
@eseliger eseliger changed the title Experimental non-on-demand dotcom: Remove on-demand cloning of repositories Jun 26, 2024
@eseliger eseliger marked this pull request as ready for review June 26, 2024 05:04
@eseliger eseliger requested a review from a team June 26, 2024 05:04
@eseliger eseliger merged commit 83d0f68 into main Jun 26, 2024
@eseliger eseliger deleted the es/06-18-experimentalnon-on-demand branch June 26, 2024 21:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants