This repository was archived by the owner on Sep 30, 2024. It is now read-only.
dotcom: Remove on-demand cloning of repositories#63321
Merged
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1422731 to
1935fb9
Compare
sqs
approved these changes
Jun 24, 2024
e33caea to
e6e7edf
Compare
e6e7edf to
e1d2d3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Historically, sourcegraph.com has been the only instance. It was connected to GitHub.com and GitLab.com only.
Configuration should be as simple as possible, and we wanted everyone to try it on any repo. So public repos were added on-demand when browsed from these code hosts.
Since, dotcom is no longer the only instance, and this is a special case that only exists for sourcegraph.com.
This causes a bunch of additional complexity and various extra code paths that we don't test well enough today.
We want to make dotcom simpler to understand, so we've made the decision to disable that feature, and instead we will maintain a list of repositories that we have on the instance.
We already disallowed several repos half a year ago, by restricting size of repos with few stars heavily.
This is basically just a continuation of that.
In the diff, you'll mostly find deletions. This PR does not do much other than removing the code paths that were only enabled in dotcom mode in the repo syncer, and then removes code that became unused as a result of that.
Test plan
Ran a dotcom mode instance locally, it did not behave differently than a regular instance wrt. repo cloning.
We will need to verify during the rollout that we're not suddenly hitting code paths that don't scale to the dotcom size.
Changelog
Dotcom no longer clones repos on demand.