This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(svelte): Fix icon color in search sidebar#63288
Merged
fkling merged 3 commits intoJun 17, 2024
Merged
Conversation
When selecting a file filter in the search sidebar the file icon doesn't change color and is often difficult to see against the selected background color. This commit fixes that an cleans up the icon coloring logic to be more consistent: All icons now have the default icon color `--icon-color`, which is set globally. This color can be overridden by setting `--icon-color` "locally", i.e. closer to the icon.
camdencheek
reviewed
Jun 17, 2024
| <path | ||
| d="M17.5756 12.1801C18.1216 12.7075 18.1437 13.5851 17.625 14.1403L17.1423 14.6569C13.3654 18.6994 6.99777 18.5987 3.34628 14.4387C2.84481 13.8674 2.89377 12.9909 3.45565 12.481C4.01752 11.9711 4.87954 12.0209 5.38102 12.5922C7.97062 15.5424 12.4865 15.6139 15.1651 12.747L15.6477 12.2304C16.1664 11.6752 17.0296 11.6527 17.5756 12.1801Z" | ||
| fill="var(--icon-fill-color, #00cbec)" | ||
| fill="var(--icon-color, #00cbec)" |
Member
There was a problem hiding this comment.
If icon color is set globally, won't this make us unable to use the colored form of the icon? Or should we be doing something like --icon-color: unset to opt-in to the colors?
Contributor
Author
There was a problem hiding this comment.
Mmmh, I guess you are right. I originally set it up to have no default. I just fixed it with --icon-color: initial.
It doesn't feel great to me but @taiyab suggested that having a default icon color is better than the other way round.
Should we go the other way though at some point I hope that it's not too difficult (yet) to do that.
camdencheek
approved these changes
Jun 17, 2024
fkling
added a commit
that referenced
this pull request
Jun 20, 2024
Closes srch-458 This implements the new fuzzy finder design, specifically: - Backdrop and dropshadow - Border radius - Tab header (affects all tab headers) - Options Note 1: Some aspects of the options UI (such as how paths are rendered and highlighted), and the "footer" depend on how the highlighted parts are computed. This will change when the local matching and ranking logic is removed and will be updated when that happens. Note 2: The symbol icon coloring was broken by #63288 and will be fixed in a separate PR. ## Test plan Manual testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes srch-552
When selecting a file filter in the search sidebar the file icon doesn't change color and is often difficult to see against the selected background color.
This commit fixes that and cleans up the icon coloring logic to be more consistent: All icons now have the default icon color
--icon-color, which is set globally. This color can be overridden by setting--icon-color"locally", i.e. closer to the icon.--icon-fill-colorand--colorwas removed.Test plan
Manual inspection. I looked at most places where we have icons and compared them to the production version.