This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/gitserver: avoid logspam from deadline exceeded memory tracking errors#63215
Merged
ggilmore merged 1 commit intoJun 12, 2024
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
eseliger
approved these changes
Jun 11, 2024
Member
There was a problem hiding this comment.
Another way would be to compare the err to ctx.Err() in case there are other conditions too.
Contributor
Author
There was a problem hiding this comment.
I'm not sure how exactly this could work, as it's possible for the error from the observer to be a multi error or wrapped.
|
|
b7fa330 to
936e9a1
Compare
936e9a1 to
ed8b4fc
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tweaks the logic in the gitserver new command logic to avoid printing errors from the memory observer if the context error is deadline exceeded.
Test plan
Unit tests
Changelog