This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
…ontext cancellation
e7e74ff to
6297e51
Compare
eseliger
approved these changes
Jun 11, 2024
Comment on lines
+317
to
322
| if memoryError != nil { | ||
| if !(errors.IsContextCanceled(memoryError) && errors.IsContextCanceled(rc.ctx.Err())) { | ||
| // If the context was canceled, we don't log the error as it's expected. | ||
| rc.logger.Warn("failed to get max memory usage", log.Error(memoryError)) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I wonder if it would be slightly more ergonomic if we made the observer independent of the context since you have to call stop anyways, but no blocker
Contributor
Author
There was a problem hiding this comment.
I still like the idea of being able to cancel the goroutines as soon as we know that the user cancelled the request, as opposed to having to wait for an explicit stop.
|
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the git cli commands to ignore errors from the memory observer if they occurred due to cancellation. Such errors are expected if the user cancels the request, and so there is no reason to generate logspam.
Test plan
Existing CI tests
This PR only reduces logspam, and as such doesn't need extensive new unit tests.
Changelog