Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

feat/internal/memcmd: ignore context cancellation errors from Stop()#63208

Merged
ggilmore merged 1 commit into
mainfrom
06-11-feat_internal_memcmd_ignore_context_cancellation_errors_from_stop_
Jun 11, 2024
Merged

feat/internal/memcmd: ignore context cancellation errors from Stop()#63208
ggilmore merged 1 commit into
mainfrom
06-11-feat_internal_memcmd_ignore_context_cancellation_errors_from_stop_

Conversation

@ggilmore

@ggilmore ggilmore commented Jun 11, 2024

Copy link
Copy Markdown
Contributor

This PR tweaks the memory observer implementation to ignore context cancellation if they only occurred if we explicitly called Stop (which calls the context's cancellation function). This helps to reduce logspam.

Test plan

Unit tests

Changelog

  • Slightly improve logspam from Linux memory observation logic by ignoring context cancellation errors that occur when the user explicitly stopped the observer.

@cla-bot cla-bot Bot added the cla-signed label Jun 11, 2024
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Jun 11, 2024

ggilmore commented Jun 11, 2024

Copy link
Copy Markdown
Contributor Author

@ggilmore ggilmore requested a review from a team June 11, 2024 19:12
@ggilmore ggilmore marked this pull request as ready for review June 11, 2024 19:12
@graphite-app

graphite-app Bot commented Jun 11, 2024

Copy link
Copy Markdown

Fire Thumbs Up GIF (Added via Giphy)

@ggilmore ggilmore merged commit b0d5452 into main Jun 11, 2024
@ggilmore ggilmore deleted the 06-11-feat_internal_memcmd_ignore_context_cancellation_errors_from_stop_ branch June 11, 2024 19:23

Copy link
Copy Markdown
Contributor Author

Merge activity

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants