This repository was archived by the owner on Sep 30, 2024. It is now read-only.
webhooks: Add support for secrets for Bitbucket Cloud#63198
Merged
eseliger merged 1 commit intoJun 18, 2024
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
d4321b2 to
0d74a8d
Compare
We didn't support secrets for bitbucket cloud so far, but the code host does support them. They use the same mechanism as Bitbucket and GitHub so that was easy to add. Test plan: Set up a webhook locally and tested that with a wrong secret it fails, and with the correct secret it passes. Also wrote a test.
0d74a8d to
658b458
Compare
ggilmore
reviewed
Jun 11, 2024
| function codeHostSupportsSecretes(codeHostKind: ExternalServiceKind): boolean { | ||
| if (codeHostKind === ExternalServiceKind.BITBUCKETCLOUD || codeHostKind === ExternalServiceKind.AZUREDEVOPS) { | ||
| function codeHostSupportsSecrets(codeHostKind: ExternalServiceKind): boolean { | ||
| if (codeHostKind === ExternalServiceKind.AZUREDEVOPS) { |
Contributor
There was a problem hiding this comment.
I wonder if would be better to use an exhaustive switch statement here (with no default)? This way the typescript compiler can help us in the future if we had a new code host kind by telling us when we haven't handled a case.
Ex
Suggested change
| if (codeHostKind === ExternalServiceKind.AZUREDEVOPS) { | |
| switch (codeHostKind) { | |
| case ExternalServiceKind.AZUREDEVOPS: | |
| return false | |
| case ExternalServiceKind.BITBUCKETCLOUD: | |
| return true | |
| // ... | |
| } |
ggilmore
reviewed
Jun 11, 2024
| "io" | ||
| "net/http" | ||
|
|
||
| gh "github.com/google/go-github/v55/github" |
Contributor
There was a problem hiding this comment.
This is a bit of an odd import here...
ggilmore
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We didn't support secrets for bitbucket cloud so far, but the code host does support them. They use the same mechanism as Bitbucket and GitHub so that was easy to add.
Closes SRC-393
Test plan:
Set up a webhook locally and tested that with a wrong secret it fails, and with the correct secret it passes. Also wrote a test.