This repository was archived by the owner on Sep 30, 2024. It is now read-only.
webhooks: Update payload testdata and type for Bitbucket Server push events#63161
Merged
eseliger merged 1 commit intoJun 12, 2024
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
…events The plugin did not actually support push events yet, so this was newly added. Not sure where the existing testdata came from, maybe the bitbucket native webhooks that don't support global scope, but this event was never handled right. To make sure we actually support the payload returned from the plugin, this PR adjusts the payload. Test plan: CI passes with the new testdata, and with the updated event type.
bd96bff to
e3daed9
Compare
ggilmore
approved these changes
Jun 11, 2024
ggilmore
left a comment
Contributor
There was a problem hiding this comment.
I don't know how the payload itself was updated, but I assume it's correct. It would be nice to have it in documented / in the PR description though.
Member
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin did not actually support push events yet, so this was newly added.
Not sure where the existing testdata came from, maybe the bitbucket native webhooks that don't support global scope, but this event was never handled right.
To make sure we actually support the payload returned from the plugin, this PR adjusts the payload.
This payload was gathered by running the bitbucket server plugin, configuring a webhook to point at a local ngrok, and then pushing to a repo.
The payload then appears in the ngrok UI.
Works on SRC-387
Test plan:
CI passes with the new testdata, and with the updated event type.