This repository was archived by the owner on Sep 30, 2024. It is now read-only.
scim: Fix user updates when SCIM was previously enabled#63135
Merged
eseliger merged 1 commit intoJun 6, 2024
Conversation
When the user external account entry for SCIM has been deleted in the past, updating the user again fails as the deleted record is found and then the insertion fails. This PR fixes that by adjusting the unique index to only consider non-soft-deleted external accounts. Test plan: Added a test suite for the DB method - it was untested before :(
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vdavid
approved these changes
Jun 6, 2024
vdavid
left a comment
Contributor
There was a problem hiding this comment.
Nice, looks good, and thanks for the test! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user external account entry for SCIM has been deleted in the past, updating the user again fails as the deleted record is found and then the insertion fails.
This PR fixes that by adjusting the unique index to only consider non-soft-deleted external accounts.
Closes SRC-383
Test plan:
Added a test suite for the DB method - it was untested before :(