This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Reapply "gitserver(client): Reintroduce 500 maximum connections limit"#63134
Merged
Conversation
ggilmore
approved these changes
Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first attempt didn't work as there are other exit conditions for the stream version than just calling RecvMsg until io.EOF. I found that gRPC has a callback for onFinish, and this seems to work properly locally.
See commit number 2 for the diff over the initial implementation.
Test plan
Verified locally that all connection counts drop to zero eventually.