This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver(client): Reintroduce 500 maximum connections limit#63064
Merged
eseliger merged 2 commits intoJun 6, 2024
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
f9da7fc to
a5989f5
Compare
ggilmore
reviewed
Jun 4, 2024
pjlast
approved these changes
Jun 6, 2024
This used to exist in the HTTP world, and we currently have zero safeguards to prevent clients from making one billion requests concurrently. Until we invest more into server-side rate limiting, or per tenant rate limiting, we reintroduce this limiter, to prevent resource usage spikes. Test plan: Added a test suite.
f592bed to
939a586
Compare
Co-authored-by: Geoffrey Gilmore <geoffrey@sourcegraph.com>
939a586 to
12313e6
Compare
eseliger
added a commit
that referenced
this pull request
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This used to exist in the HTTP world, and we currently have zero safeguards to prevent clients from making one billion requests concurrently.
Until we invest more into server-side rate limiting, or per tenant rate limiting, we reintroduce this limiter, to prevent resource usage spikes.
Test plan:
Added a test suite.