This repository was archived by the owner on Sep 30, 2024. It is now read-only.
repoupdater(scheduler): Prevent race condition of schedule preloading#63086
Merged
eseliger merged 1 commit intoJun 4, 2024
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mmanela
approved these changes
Jun 4, 2024
Contributor
There was a problem hiding this comment.
Were there no tests for this?
Member
Author
There was a problem hiding this comment.
sigh - no. The scheduler and all the ~10 things that work together to fill the schedule are very poorly tested unfortunately :/
Member
Author
There was a problem hiding this comment.
actually - I take that back, this was covered by another test :)
My local instance has few repos enough that this doesn't happen, but on larger instances this preloading fights with the new preloading. They are both best effort, and are meant to achieve the same thing. Thus, this one is not required anymore, and we can delete it, after we added another one in https://github.com/sourcegraph/sourcegraph/pull/62891. Test plan: Verified with sleeps and logs locally that repos are correctly upserted in the schedule now.
08f9403 to
3407fdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My local instance has few repos enough that this doesn't happen, but on larger instances this preloading fights with the new preloading.
They are both best effort, and are meant to achieve the same thing.
Thus, this one is not required anymore, and we can delete it, after we added another one in https://github.com/sourcegraph/sourcegraph/pull/62891.
Test plan:
Verified with sleeps and logs locally that repos are correctly upserted in the schedule now.