This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver(fs): Remove caching of cloned state#63066
Merged
Merged
Conversation
I thought it might be nice to save on a few IOPS from the Stat calls to check if a repo is cloned by caching it for a bit. But turns out that the mutex locking and unlocking is more expensive than the stat operation. We can come back here later and see if we can optimize it, we never had this in the past so this will be no regression. Some background on mutex performance: https://stackoverflow.com/questions/57562606/why-does-sync-mutex-largely-drop-performance-when-goroutine-contention-is-more-t Closes SRC-322 Test plan: Without the cache, the tests still pass.
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ggilmore
approved these changes
Jun 4, 2024
ggilmore
left a comment
Contributor
There was a problem hiding this comment.
You can try using lock striping as a strategy to reduce contention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought it might be nice to save on a few IOPS from the Stat calls to check if a repo is cloned by caching it for a bit. But turns out that the mutex locking and unlocking is more expensive than the stat operation.
We can come back here later and see if we can optimize it, we never had this in the past so this will be no regression.
Some background on mutex performance: https://stackoverflow.com/questions/57562606/why-does-sync-mutex-largely-drop-performance-when-goroutine-contention-is-more-t
Closes SRC-322
Test plan:
Without the cache, the tests still pass.