This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Fix some cases of RevNotFound in CommitLog#63063
Merged
eseliger merged 1 commit intoJun 4, 2024
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ggilmore
reviewed
Jun 4, 2024
Contributor
There was a problem hiding this comment.
I think this would be easier to read if this was all extracted to a for loop
Suggested change
| if bytes.Contains(e.Stderr, []byte("not a tree object")) || | |
| var errMessages = []string{ | |
| "not a tree object", | |
| "fatal: bad object", | |
| "fatal: ambiguous argument", | |
| "unknown revision or path not in the working tree.", | |
| "fatal: Invalid revision range", | |
| "fatal: bad revision", | |
| } | |
| for _, message := range errMessages { | |
| if bytes.Contains(e.Stderr, []byte(message)) { | |
| return &gitdomain.RevisionNotFoundError{Repo: it.repoName, Spec: it.spec} | |
| } | |
| } |
ggilmore
approved these changes
Jun 4, 2024
There are so many different error messages this can return .. we seem to have missed a few that we need to map to RevisionNotFound, found in dotcom gitserver logs. Test plan: Added tests for the cases.
76639b4 to
10b3af2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are so many different error messages this can return .. we seem to have missed a few that we need to map to RevisionNotFound, found in dotcom gitserver logs.
Test plan:
Added tests for the cases.