This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Remove IsCloneable check from clone path#63028
Merged
eseliger merged 1 commit intoJun 3, 2024
Conversation
We made this preflight check always, and the doc string said that it's for "better error messages". I checked on that, and the additional RPS claim and the additional latency of the iscloneable check plus load on the code host don't seem justified. Error message before this change: ``` Error updating repo: failed to clone dev.azure.com/sourcegraph-source/src-cli/src-cli: error cloning repo: repo dev.azure.com/sourcegraph-source/src-cli/src-cli not cloneable: failed to check remote access: fatal: Authentication failed for 'https://dev.azure.com/sourcegraph-source/src-cli/_git/src-cli/': exit status 128 ``` Error message after this change: ``` Error updating repo: failed to clone dev.azure.com/sourcegraph-source/src-cli/src-cli: clone failed. Output: Creating bare repo Created bare repo at /Users/erik/.sourcegraph/repos_1/.tmp/clone-2786287217/.git Fetching remote contents fatal: Authentication failed for 'https://dev.azure.com/sourcegraph-source/src-cli/_git/src-cli/': failed to fetch: exit status 128: command failed: exit status 128 ``` Not much worse or less readable. Closes https://github.com/sourcegraph/sourcegraph/issues/62786 Test plan: Adjusted tests, made sure repos still clone alright and throw a somewhat useful error message on failure.
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
pjlast
approved these changes
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We made this preflight check always, and the doc string said that it's for "better error messages".
I checked on that, and the additional RPS claim and the additional latency of the iscloneable check plus load on the code host don't seem justified.
Error message before this change:
Error message after this change:
Not much worse or less readable.
Closes https://github.com/sourcegraph/sourcegraph/issues/62786
Test plan:
Adjusted tests, made sure repos still clone alright and throw a somewhat useful error message on failure.