Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

gitserver: Add observability for repo service#63026

Merged
eseliger merged 1 commit into
mainfrom
es/06-03-gitserveraddobservabilityforreposervice
Jun 3, 2024
Merged

gitserver: Add observability for repo service#63026
eseliger merged 1 commit into
mainfrom
es/06-03-gitserveraddobservabilityforreposervice

Conversation

@eseliger

@eseliger eseliger commented Jun 3, 2024

Copy link
Copy Markdown
Member

Since we split out this service, we lost a few metrics on call counts and latencies.
This PR adds them back.

Closes #62785

Test plan:

Ran the dashboards locally and they return data. These dashboards are a 1:1 replica of the git service observability.

@cla-bot cla-bot Bot added the cla-signed label Jun 3, 2024
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Jun 3, 2024

eseliger commented Jun 3, 2024

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @eseliger and the rest of your teammates on Graphite Graphite

Since we split out this service, we lost a few metrics on call counts and latencies.
This PR adds them back.

Closes #62785

Test plan:

Ran the dashboards locally and they return data. These dashboards are a 1:1 replica of the git service observability.
@eseliger eseliger force-pushed the es/06-03-gitserveraddobservabilityforreposervice branch from ac249e5 to 6487c96 Compare June 3, 2024 06:02
@eseliger eseliger marked this pull request as ready for review June 3, 2024 06:38
@eseliger eseliger requested a review from a team June 3, 2024 06:38
@eseliger eseliger merged commit 6d142c8 into main Jun 3, 2024
@eseliger eseliger deleted the es/06-03-gitserveraddobservabilityforreposervice branch June 3, 2024 14:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add gitserver repository service to gRPC grafana dashboards

2 participants