Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

feat/sg/msp: add 'sg msp validate' for validating service specifications#62973

Merged
bobheadxi merged 1 commit into
mainfrom
05-29-feat_sg_msp_add_sg_msp_validate_for_validating_service_specifications
May 30, 2024
Merged

feat/sg/msp: add 'sg msp validate' for validating service specifications#62973
bobheadxi merged 1 commit into
mainfrom
05-29-feat_sg_msp_add_sg_msp_validate_for_validating_service_specifications

Conversation

@bobheadxi

@bobheadxi bobheadxi commented May 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Simple way to test changes to validations, and maybe helpful for operators too.

Test plan

Testing: https://github.com/sourcegraph/sourcegraph/pull/62972

Projects/sourcegraph/managed-services » sg msp validate
✅ [build-tracker] Validated
✅ [cloud-ops] Validated
✅ [cloud-relay] Validated
✅ [cloud-scheduler] Validated
✅ [cody-analytics] Validated
✅ [enterprise-portal] Validated
✅ [entitler] Validated
✅ [gatekeeper] Validated
✅ [linearhooks] Validated
✅ [msp-testbed] Validated
✅ [pings] Validated
✅ [releaseregistry] Validated
❌ [repoferee] Found valdiation errors

                                                                                                                                
  • environment "prod" in category "internal" requires 'service.notionPageID' to be set                                         


✅ [sams] Validated
✅ [sourcegraph-accounts] Validated
✅ [support-hygiene] Validated
✅ [support-integration] Validated
✅ [telemetry-gateway] Validated
Checked 18 service specifications

Changelog

  • sg msp validate can now be used to get quick feedback on whether MSP service specifications are valid.

@cla-bot cla-bot Bot added the cla-signed label May 29, 2024
@bobheadxi Graphite App

bobheadxi commented May 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bobheadxi and the rest of your teammates on Graphite Graphite

@bobheadxi bobheadxi mentioned this pull request May 29, 2024
Merged
@bobheadxi bobheadxi marked this pull request as ready for review May 29, 2024 19:49
@bobheadxi bobheadxi requested a review from a team May 29, 2024 19:50
Base automatically changed from sg-msp-require-notion-page to main May 30, 2024 16:01
@bobheadxi bobheadxi force-pushed the 05-29-feat_sg_msp_add_sg_msp_validate_for_validating_service_specifications branch from 79d9be7 to b2fa057 Compare May 30, 2024 16:03
@bobheadxi Graphite App

bobheadxi commented May 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Merge activity

  • May 30, 12:03 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 30, 12:11 PM EDT: @bobheadxi merged this pull request with Graphite.

@bobheadxi bobheadxi merged commit 9e4a8e8 into main May 30, 2024
@bobheadxi bobheadxi deleted the 05-29-feat_sg_msp_add_sg_msp_validate_for_validating_service_specifications branch May 30, 2024 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@unknwon unknwon unknwon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bobheadxi @unknwon