This repository was archived by the owner on Sep 30, 2024. It is now read-only.
uploads: Fixup nested code intel uploads#62931
Merged
Merged
Conversation
I misinterpreted what the client-side version of this did, and accidentally skipped over directories, which meant that it would not traverse deeply into folders. This caused uploads to be incomplete. Might close GRAPH-632. Test plan: Manually verified the before and after behavior and they feel equal to me now from a quick debugger session. But I don't see precise in my local instance, so perhaps this needs more work.
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ggilmore
approved these changes
May 28, 2024
ggilmore
left a comment
Contributor
There was a problem hiding this comment.
I would love a test for this behavior, but I understand that that might require a lot more infra (cc @sourcegraph/team-graph )
Member
Author
|
Merging to make sure it doesn't miss the release train, but happy to do more follow ups. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I misinterpreted what the client-side version of this did, and accidentally skipped over directories, which meant that it would not traverse deeply into folders. This caused uploads to be incomplete.
Might close GRAPH-632.
Test plan:
Manually verified the before and after behavior and they feel equal to me now from a quick debugger session.
But I don't see precise in my local instance, so perhaps this needs more work.