This repository was archived by the owner on Sep 30, 2024. It is now read-only.
svelte: Add lucide icons and new icon API#62908
Merged
Merged
Conversation
61a2b57 to
de4b892
Compare
camdencheek
approved these changes
May 24, 2024
camdencheek
left a comment
Member
There was a problem hiding this comment.
LGTM! Stamping to unblock, but did not run it locally
vovakulikov
reviewed
May 28, 2024
vovakulikov
reviewed
May 28, 2024
vovakulikov
approved these changes
May 28, 2024
I have no idea why but moving the module declaration to `global.d.ts` seems to fix the issue.
3c127e6 to
4964554
Compare
fkling
added a commit
that referenced
this pull request
May 31, 2024
This PR adds the inline file search to the file view. ## Changelog - Refactored the existing CodeMirror extension to allow UI customization - Moved utility functions around to avoid loading all of wildcard into the prototype (which lead to build errors) - Tweaked the new icon component to better align within buttons (I missed that in #62908 because I didn't test it within buttons) - Noticed that button group styles didn't apply correctly and the reason seemed to be that we were mixing sveltekit and react styles. So I copied the button styles into the sveltekit app. - Added a switch component, following https://web.dev/articles/building/a-switch-component .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also #62904.
This PR adds a new icon component (
Icon2), which takes an svg component imported byunplugin-icons. To make things easier the icons can be auto-imported viaunplugin-auto-import.Usage example:
unplugin-iconsallows us to:react-icons, which we use in the React app, also pulls from multiple icon sets.See https://github.com/unplugin/unplugin-icons for more information.
If it turns out that auto-importing (which involves generating TypeScrip types) doesn't work with our Bazel pipeline we can fall back to manual importing.
This PR converts some icons as example.
Test plan
Manual testing.