This repository was archived by the owner on Sep 30, 2024. It is now read-only.
perforce: Add fallback logic for changelist mapper#62871
Merged
eseliger merged 1 commit intoMay 29, 2024
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
94e10fc to
d258aea
Compare
d258aea to
73bfcc2
Compare
ggilmore
reviewed
May 23, 2024
Contributor
There was a problem hiding this comment.
small preference: would prefer having dedicate variable name for this (would help with setting breakpoints if I want to)
Suggested change
| MessageQuery: fmt.Sprintf("change = %d]", cid), | |
| messageQuery := fmt.Sprintf("change = %d]", cid) | |
| MessageQuery: messageQuery, |
ggilmore
reviewed
May 23, 2024
Contributor
There was a problem hiding this comment.
I see that we're swallowing the error here. Can we possibly log it/ add it to the trace?
ggilmore
approved these changes
May 23, 2024
73bfcc2 to
45ce7f7
Compare
When the changelist mapper has not yet indexed a changelist ID for fast lookup, we try to find it via git log instead to bridge the time between a git fetch and the new commit SHAs being indexed better. Test plan: Verified locally that with an empty DB changelist IDs still show up.
45ce7f7 to
819282c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the changelist mapper has not yet indexed a changelist ID for fast lookup, we try to find it via git log instead to bridge the time between a git fetch and the new commit SHAs being indexed better.
Test plan:
Verified locally that with an empty DB changelist IDs still show up.