This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Clean up some errors from improper API usage#62787
Merged
eseliger merged 1 commit intoMay 21, 2024
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6a22336 to
3ae037e
Compare
Unfortunately, some callers seem to be passing non-20-byte OIDs through api.CommitID fields. We should ultimately clean that up, but in the meantime this should help make the error messages clearer and reduce noise from strange error messages. Test plan: Added tests to cover for the cases where this can happen.
3ae037e to
38327fc
Compare
ggilmore
approved these changes
May 21, 2024
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, some callers seem to be passing non-20-byte OIDs through api.CommitID fields.
We should ultimately clean that up, but in the meantime this should help make the error messages clearer and reduce noise from strange error messages.
Test plan:
Added tests to cover for the cases where this can happen.