This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Cleanup CreateCommitFromPatch#62781
Merged
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
a5a2c86 to
26aca2f
Compare
ggilmore
approved these changes
Jun 6, 2024
This method is still quite messy, but here's some incremental improvement: - The unused unique_ref parameter has been removed to simplify - The git_apply_args parameter has been replaced with patch_filenames_no_prefix, to not allow arbitrary arguments to be passed from clients for improved security - The repo existence check now lives in the gRPC layer like for all other resolvers - Added a docstring to describe how it works Test plan: Integration tests are still passing, created a batch change locally to verify it can still correctly create a PR.
26aca2f to
42cc1b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method is still quite messy, but here's some incremental improvement:
Test plan:
Integration tests are still passing, created a batch change locally to verify it can still correctly create a PR.