This repository was archived by the owner on Sep 30, 2024. It is now read-only.
repoupdater: Add retry policy to repositoryservice#62778
Merged
eseliger merged 1 commit intoMay 21, 2024
Conversation
This new client didn't have any retries set, so we would always fast-fail when gitserver is unavailable. That makes the operation more noisy than it has to be, and potentially all repos back in the fetch queue, because it thinks the fetch itself failed. All these methods are safe to be called a second time, so we can safely do that. This is an easy fix to ensure repo updater waits a bit for gitserver to be back online. Test plan: Verified locally that fetches don't immediately fail when gitserver is down.
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new client didn't have any retries set, so we would always fast-fail when gitserver is unavailable. That makes the operation more noisy than it has to be, and potentially all repos back in the fetch queue, because it thinks the fetch itself failed.
All these methods are safe to be called a second time, so we can safely do that.
This is an easy fix to ensure repo updater waits a bit for gitserver to be back online.
Test plan:
Verified locally that fetches don't immediately fail when gitserver is down.