This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Switch corruption logs to use separate file#62775
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
0f5c133 to
7d9ada6
Compare
ggilmore
approved these changes
May 21, 2024
We still incur a ton of git config calls, those add pressure to the process spawning, so we instead do a much cheaper fs.Stat now to check for corruption. Test plan: Adjusted tests, CI and integration tests still pass.
7d9ada6 to
f7165cb
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We still incur a ton of git config calls, those add pressure to the process spawning, so we instead do a much cheaper fs.Stat now to check for corruption.
Test plan:
Adjusted tests, CI and integration tests still pass.