This repository was archived by the owner on Sep 30, 2024. It is now read-only.
authz: Fix panic when auth provider is missing#62759
Merged
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mmanela
approved these changes
May 17, 2024
5b338ba to
c6c5ed3
Compare
When authz is enabled for a GitHub code host connection, but there is no corresponding auth.providers entry, this code currently panics, because `GetOAuthContext` returns nil, and then the `RefreshFunc` in the OAuthBearerToken tries to use that context when it refreshes. This is a misconfiguration, and cannot work (we need both the authz setting, and the auth provider), but the worker pod should not just panic because of that, so we return a nicer error here now. Test plan: Added a unit test.
c6c5ed3 to
51275bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When authz is enabled for a GitHub code host connection, but there is no corresponding auth.providers entry, this code currently panics, because
GetOAuthContextreturns nil, and then theRefreshFuncin the OAuthBearerToken tries to use that context when it refreshes.This is a misconfiguration, and cannot work (we need both the authz setting, and the auth provider), but the worker pod should not just panic because of that, so we return a nicer error here now.
Test plan:
Added a unit test.