Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore: Move cmd/searcher/protocol to internal/searcher/protocol#62714

Merged
eseliger merged 1 commit into
mainfrom
es/05-16-choremovecmdsearcherprotocoltointernalsearcherprotocol
May 16, 2024
Merged

chore: Move cmd/searcher/protocol to internal/searcher/protocol#62714
eseliger merged 1 commit into
mainfrom
es/05-16-choremovecmdsearcherprotocoltointernalsearcherprotocol

Conversation

@eseliger

Copy link
Copy Markdown
Member

Camden and I noticed while hacking together today that we import the searcher protocol across cmd/ boundaries, so this PR moves it to internal, which is in line with what we do for gitserver.

Test plan:

Bazel and go compiler don't complain.

Camden and I noticed while hacking together today that we import the searcher protocol across cmd/ boundaries, so this PR moves it to internal, which is in line with what we do for gitserver.

Test plan:

Bazel and go compiler don't complain.
@cla-bot cla-bot Bot added the cla-signed label May 16, 2024

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @eseliger and the rest of your teammates on Graphite Graphite

@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels May 16, 2024
@eseliger eseliger marked this pull request as ready for review May 16, 2024 03:12
@eseliger eseliger requested review from a team and camdencheek May 16, 2024 03:12

@0xnmn 0xnmn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eseliger eseliger enabled auto-merge (squash) May 16, 2024 13:38
@eseliger eseliger merged commit 2fc9a80 into main May 16, 2024
@eseliger eseliger deleted the es/05-16-choremovecmdsearcherprotocoltointernalsearcherprotocol branch May 16, 2024 13:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants