This repository was archived by the owner on Sep 30, 2024. It is now read-only.
inference: Fix regression for non-absolute commit ID#62711
Merged
eseliger merged 1 commit intoMay 16, 2024
Conversation
The previous local implementation allowed anything for the commitID passed, and we pass things like HEAD and such here, which are not actually commits. So we first let gitserver resolve it to an actual commit ID now. This will resolve https://sourcegraph.sentry.io/issues/5333275545/?project=6583153&query=is%3Aunresolved++non-absolute+commit+ID&referrer=issue-stream&statsPeriod=14d&stream_index=0. Test plan: Code review and will mark the issue as resolved and watch for regression notifications.
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
pjlast
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous local implementation allowed anything for the commitID passed, and we pass things like HEAD and such here, which are not actually commits.
So we first let gitserver resolve it to an actual commit ID now.
This will resolve https://sourcegraph.sentry.io/issues/5333275545/?project=6583153&query=is%3Aunresolved++non-absolute+commit+ID&referrer=issue-stream&statsPeriod=14d&stream_index=0.
Test plan:
Code review and will mark the issue as resolved and watch for regression notifications.