This repository was archived by the owner on Sep 30, 2024. It is now read-only.
observability: Fix error checks in ErrorsFilter#62710
Merged
eseliger merged 1 commit intoMay 16, 2024
Merged
Conversation
The ErrorsFilter function can be used to skip over well known errors for certain log targets. Multiple errors can all be collected in a wrapper, the ErrCollector. The collector wraps the errors it found, but it doesn't implement Unwrap, so errors.Is and errors.HasType don't work properly here, they will only see the ErrCollector. This PR adds Unwrap to the ErrCollector to fix that, and fixes the error code detection in gitserver git observability, and makes it less aggressive in what we skip. Test plan: Verified that the two errors are no longer erroneously logged.
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bobheadxi
approved these changes
May 15, 2024
| return observation.EmitForNone | ||
| return observation.EmitForHoney | observation.EmitForTraces | ||
| } | ||
| if os.IsNotExist(err) { |
Member
There was a problem hiding this comment.
I'm surprised standard library doesn't unwrap 👀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ErrorsFilter function can be used to skip over well known errors for certain log targets. Multiple errors can all be collected in a wrapper, the ErrCollector.
The collector wraps the errors it found, but it doesn't implement Unwrap, so errors.Is and errors.HasType don't work properly here, they will only see the ErrCollector.
This PR adds Unwrap to the ErrCollector to fix that, and fixes the error code detection in gitserver git observability, and makes it less aggressive in what we skip.
Test plan:
Verified that the two errors are no longer erroneously logged.