Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

URL Path Escape Model Name#62642

Merged
RXminuS merged 2 commits into
mainfrom
rnauta/fix/p-arn-model
May 14, 2024
Merged

URL Path Escape Model Name#62642
RXminuS merged 2 commits into
mainfrom
rnauta/fix/p-arn-model

Conversation

@RXminuS

@RXminuS RXminuS commented May 13, 2024

Copy link
Copy Markdown
Contributor

URL Model names weren't path-escaped leading to issues with Bedrock provisioned throughput model names that include : and / characters.

Test plan

  • Existing unit tests should pass

@RXminuS RXminuS added the p0 label May 13, 2024
@cla-bot cla-bot Bot added the cla-signed label May 13, 2024
@RXminuS RXminuS requested review from a team, eseliger and loujar May 13, 2024 23:37

@eseliger eseliger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@RXminuS RXminuS merged commit 2b13062 into main May 14, 2024
@RXminuS RXminuS deleted the rnauta/fix/p-arn-model branch May 14, 2024 09:33
DaedalusG pushed a commit that referenced this pull request May 14, 2024
* URL Path Escape Model Name

* Update changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants