This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Fixup error codes for ReadDir#62620
Merged
Merged
Conversation
I messed up the error checking here, and the test for it as well, now gitserver properly returns FileNotFoundPayloads and RevisionNotFoundPayloads for this API. Test plan: Adjusted test suite and manually verified using the gRPC UI.
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
pjlast
reviewed
May 13, 2024
Comment on lines
519
to
+524
| if cfe.ExitStatus == 128 && bytes.Contains(cfe.Stderr, []byte("fatal: not a tree object")) { | ||
| return &gitdomain.RevisionNotFoundError{Repo: it.repoName, Spec: string(it.commit)} | ||
| } | ||
| if cfe.ExitStatus == 128 && bytes.Contains(cfe.Stderr, []byte("fatal: Not a valid object name")) { | ||
| return &gitdomain.RevisionNotFoundError{Repo: it.repoName, Spec: string(it.commit)} | ||
| } |
Contributor
There was a problem hiding this comment.
Are these errors correct? I find it weird that the one starts with not and one starts with Not 🤔
pjlast
approved these changes
May 13, 2024
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I messed up the error checking here, and the test for it as well, now gitserver properly returns FileNotFoundPayloads and RevisionNotFoundPayloads for this API.
Test plan:
Adjusted test suite and manually verified using the gRPC UI.