This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: More sophisticated argument building#62617
Closed
eseliger wants to merge 1 commit into
Closed
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6541dbc to
2624f11
Compare
Base automatically changed from
es/04-21-gitservermovespecargsafetycheckintogitlayer
to
main
May 13, 2024 12:22
2624f11 to
f505870
Compare
This PR aims to improve our command building and validation. Previously, every internal command would need to be added to the command allow list. This meant that whatever we allow internal actors to do, we would also need to allow callers of exec to do, which exposes some risk. This PR aims to clean up with that by marking certain arguments that we hard-code as safe, and verifies the other ones for safety. Test plan: E2E and integration tests are still passing, requesting review from security.
f505870 to
9c3e846
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to improve our command building and validation. Previously, every internal command would need to be added to the command allow list.
This meant that whatever we allow internal actors to do, we would also need to allow callers of exec to do, which exposes some risk.
This PR aims to clean up with that by marking certain arguments that we hard-code as safe, and verifies the other ones for safety.
Test plan:
E2E and integration tests are still passing, requesting review from security.